Re: [patch 2/3] regset IA64 implementation

From: Roland McGrath <roland_at_redhat.com>
Date: 2008-02-28 07:49:21
Thanks for this work, I'm very glad to see it!

The regset layouts look right to me.  Note that for full parity with native
x86, the ia32 view set needs to add NT_386_TLS too.  

It is up to ia64 to decide how the innards should look.  
However, I do have a few suggestions.

Firstly, I would recommend splitting this into a few more separate patches.
e.g. define CORE_DUMP_USE_REGSET in a separate patch after adding the
user_regset accessors.  This makes it easier to isolate problems quickly
should any arise later on, using git-bisect.

The writeback hook should use TIF_RESTORE_RSE.  If I understand correctly,
calling ia64_sync_user_rbs without regard to TIF_RESTORE_RSE might actually
break things.  It's certainly suboptimal.  Ideally, when TIF_RESTORE_RSE is
already set, you shouldn't even call into unw_*.  ia64_ptrace_stop is
nearly correct as the writeback hook already, it just needs to handle both
current and non-current task arguments.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Feb 28 07:49:35 2008

This archive was generated by hypermail 2.1.8 : 2008-02-28 07:49:51 EST