RE: [kvm-devel] [1-5/17] Patch 1-10 of kvm/ia64 V2

From: Zhang, Xiantao <xiantao.zhang_at_intel.com>
Date: 2007-12-21 19:14:13
Akio Takebe wrote:
> Hi, Xiantao
> 
>>> [3/17] Add firmware virtualization support.
> 
> +void kvm_sal_emul(struct kvm_vcpu *vcpu)
> +{
> +
> +	struct sal_ret_values result;
> +	u64 index, in1, in2, in3, in4, in5, in6, in7;
> +
> +	kvm_get_sal_call_data(vcpu, &index, &in1, &in2,
> +			&in3, &in4, &in5, &in6, &in7);
> +	if (index) {
> +		result = sal_emulator(index, in1, in2, in3,
> +						in4, in5, in6, in7);
> +		set_sal_result(vcpu, result);
> +	} else
> +		printk(KERN_WARNING"kvm:Unsupported sal call called,"
> +					" index:%d!\n", index);
> +}
> The printk always show index:0.
> And set_sal_result() doesn't work at the time of index=0.
> So I think the following code is better.

Good catch! Originally, I want to use it for kvm_get_sal_call debug, but
forget to remove it. 
Thank you! :)

> +void kvm_sal_emul(struct kvm_vcpu *vcpu)
> +{
> +
> +	struct sal_ret_values result;
> +	u64 index, in1, in2, in3, in4, in5, in6, in7;
> +
> +	kvm_get_sal_call_data(vcpu, &index, &in1, &in2,
> +			&in3, &in4, &in5, &in6, &in7);
> +	result = sal_emulator(index, in1, in2, in3,
> +					in4, in5, in6, in7);
> +	set_sal_result(vcpu, result);
> +}
> 
> Best Regards,
> 
> Akio Takebe

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Dec 21 19:15:43 2007

This archive was generated by hypermail 2.1.8 : 2007-12-21 19:15:59 EST