RE: [PATCH 4 of 4] Add efi_guidtest_set to reduce duplication

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2007-12-13 10:52:03
> This is a list of duplicated tests.  Using a #define makes it easier to add new
> ones and harder to introduce an error.

The next new one to be added here is likely to be a check for the
PALO table (http://www.dig64.org/home/DIG-PALO_09a.pdf) ... but it
is unclear whether this fits the pattern dictated by your macro,
which requires that everything we find be stashed in the "efi"
structure. I'm not sure that I want/need to add a pointer to the
PALO table to "struct efi".

The series of if-then-else clauses here doesn't look too complex
or error prone (especially in the original long-line form before
you squeezed it into 80 columns in the first patch in this series).

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Dec 13 10:52:29 2007

This archive was generated by hypermail 2.1.8 : 2007-12-13 10:52:43 EST