Re: [PATCH] Move dmi_scan_machine() call ealier

From: Simon Horman <horms_at_verge.net.au>
Date: 2007-11-07 18:15:11
On Tue, Nov 06, 2007 at 10:31:07AM -0700, Alex Williamson wrote:
> 
>    I'd like to move our call to dmi_scan_machine up earlier in the boot
> process so that we can take advantage of a DMI hook, called out of
> acpi_early_init, to enable _OSI(Linux) on Xen HVM domains.  Since the
> SMBIOS parsing makes use of ioremap, which Bjorn pointed out is fragile
> early in boot, I'm reluctant to move this too much earlier.  Given those
> restrictions, it seems best to simply move this up into our check_bugs
> function.  Since the DMI hooks are mainly used for adjusting code path
> based on platform, it doesn't seem like such an unreasonable place to
> set it up.  Please let me know if you have comments.  Thanks,

I guess if that works then its ok. But if a name is worth anything,
I don't think check_bugs() really encompases the behaviour of
run_dmi_scan().

Also, you should probably fix up the comment in run_dmi_scan()
that says it is run as a core_initcall().

> 
> 	Alex
> 
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> --
> 
> diff -r c7f1be4e5832 arch/ia64/kernel/setup.c
> --- a/arch/ia64/kernel/setup.c	Thu Nov 01 12:09:33 2007 -0700
> +++ b/arch/ia64/kernel/setup.c	Tue Nov 06 09:17:32 2007 -0700
> @@ -982,11 +982,5 @@ check_bugs (void)
>  {
>  	ia64_patch_mckinley_e9((unsigned long) __start___mckinley_e9_bundles,
>  			       (unsigned long) __end___mckinley_e9_bundles);
> -}
> -
> -static int __init run_dmi_scan(void)
> -{
>  	dmi_scan_machine();
> -	return 0;
> -}
> -core_initcall(run_dmi_scan);
> +}
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Nov 07 18:16:51 2007

This archive was generated by hypermail 2.1.8 : 2007-11-07 18:17:06 EST