Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c

From: Simon Horman <horms_at_verge.net.au>
Date: 2007-11-05 20:34:25
On Mon, Nov 05, 2007 at 10:10:13AM +0100, Roel Kluin wrote:
> Simon Horman wrote:
> > On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
> >> Do iounmap if tioce_kern_init fails
> > 
> > This is covered by a subsequent patch, right?
> 
> aparently it should, what am I missing?

Nothing, I was just confirming that it is duplicated elsewhere :-)

> >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> >> ---
> >> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> >> index cee9379..128ed07 100644
> >> --- a/arch/ia64/sn/pci/tioce_provider.c
> >> +++ b/arch/ia64/sn/pci/tioce_provider.c
> >> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
> >>  
> >>  	tioce_kern = tioce_kern_init(tioce_common);
> >>  	if (tioce_kern == NULL) {
> >> +		iounmap(tioce_common->ce_pcibus.bs_base);
> >>  		kfree(tioce_common);
> >>  		return NULL;
> >>  	}
> 

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Nov 05 20:34:38 2007

This archive was generated by hypermail 2.1.8 : 2007-11-05 20:34:57 EST