Re: iounmap after ioremap in arch/ia64/sn/pci/pcibr/pcibr_provider.c

From: Simon Horman <horms_at_verge.net.au>
Date: 2007-11-05 13:15:03
On Sun, Nov 04, 2007 at 12:43:42AM +0100, Roel Kluin wrote:
> A better discription, maybe?
> --
> iounmap after ioremap

Again, this looks correct to me, so long as calling iounmap() actually
reverses ioremap() in this case.

> 
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/ia64/sn/pci/pcibr/pcibr_provider.c b/arch/ia64/sn/pci/pcibr/pcibr_provider.c
> index ab3eaf8..00d1b85 100644
> --- a/arch/ia64/sn/pci/pcibr/pcibr_provider.c
> +++ b/arch/ia64/sn/pci/pcibr/pcibr_provider.c
> @@ -186,6 +186,7 @@ pcibr_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>  
>  	if (!soft->pbi_int_ate_resource.ate) {
>  		kfree(soft);
> +		iounmap(soft->pbi_buscommon.bs_base);
>  		return NULL;
>  	}
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Nov 05 13:15:33 2007

This archive was generated by hypermail 2.1.8 : 2007-11-05 13:15:50 EST