RE: [patch] Support multiple CPUs going through OS_MCA

From: Yu, Fenghua <fenghua.yu_at_intel.com>
Date: 2007-04-28 10:34:03
>+	if (r13 != sos->prev_IA64_KR_CURRENT) {
>+		msg = "inconsistent previous current and r13";
>+		goto no_mod;
>+	}
>+
> 	if (!mca_recover_range(ms->pmsa_iip)) {
>-		if (r13 != sos->prev_IA64_KR_CURRENT) {
>-			msg = "inconsistent previous current and r13";
>-			goto no_mod;
>-		}

Could you explain whey move the r13 check out of mca_recover_range()?


>+		for_each_online_cpu(i) {
>+			if (cpu_isset(i, mca_cpu)) {
>+				monarch_cpu = i;
>+				cpu_clear(i, mca_cpu);	/* wake next cpu
*/

Just a picky comment...Is it better to changed to
+ if (mca_cpu!=0) {
+		for_each_online_cpu(i) {
+			if (cpu_isset(i, mca_cpu)) {
+				monarch_cpu = i;
+				cpu_clear(i, mca_cpu);	/* wake next cpu
*/

it may speed up a bit?. After all in reality, there are few bits set in
mca_cpu. So there is no need to go through all of online cpus.

Thanks.

-Fenghua
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sat Apr 28 10:34:30 2007

This archive was generated by hypermail 2.1.8 : 2007-04-28 10:34:51 EST