Re: [PATCH] - Optional method to purge the TLB on SN systems

From: Jack Steiner <steiner_at_sgi.com>
Date: 2007-03-28 06:33:50
On Tue, Mar 27, 2007 at 01:24:27PM -0700, Luck, Tony wrote:
> +smp_flush_tlb_cpumask (cpumask_t xcpumask)
> +{
> +	unsigned short counts[NR_CPUS];
> 
> Even as a "short" ... that is still a lot of stack.  Possibly
> a new place to fail when NR_CPUS gets bumped up again?

I was also somwhat concerned about that, too. At NR_CPUS=1024, it
uses 2k bytes whick is big but I think ok. Even at NR_CPUS=2048,
I think is is still ok but I'm getting a little nervous. 

FWIW, slab.c has a "struct array_cache *new[NR_CPUS]" on the
stack.

Also, net/core/utils.c has "unsigned long seed[NR_CPUS]".

I'm only adding 1/4 as much space. Can I get away with it or
should I allocate a node-local chunk of memory & keep a pointer to
it in per-cpu data?



> 
> +#define IA64_IPI_LOCAL_TLB_FLUSH	0xfc	/* SMP reschedule */
>  #define IA64_IPI_RESCHEDULE		0xfd	/* SMP reschedule */
> 
> Cut & pasted the comment when duping this line?

Whoops :-) 
Fixed....

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Mar 28 06:36:38 2007

This archive was generated by hypermail 2.1.8 : 2007-03-28 06:36:59 EST