Re: [Fastboot] [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0)

From: Bernhard Walle <bwalle_at_suse.de>
Date: 2007-03-20 05:37:10
* Jesper Juhl <jesper.juhl@gmail.com> [2007-03-19 19:29]:
> >
> > -void
> > +int
> >  register_percpu_irq (ia64_vector vec, struct irqaction *action)
> >  {
> 
> Each and every function example in Documentation/CodingStyle has the
> return type on the same line as the function name, so why not get
> these in-line while you are modifying them anyway?

Because all other functions in that file are coded this way. I think
it looks better if you don't change the style in a particular file.
Am I wrong?

> int register_percpu_irq (ia64_vector vec, struct irqaction *action)
> 
> 
> > @@ -174,6 +175,13 @@ void note_interrupt(unsigned int irq, st
> >         desc->irqs_unhandled = 0;
> >  }
> >
> > +
> > +void set_timer_interrupt(unsigned int irq)
> 
> Just one blank line between functions, as pr CodingStyle:
>    "In source files, separate functions with one blank line.  ..."

Fixed (locally). I'll repost if I get feedback of the contents of the
patch.


Regards,
Bernhard

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Mar 20 05:37:30 2007

This archive was generated by hypermail 2.1.8 : 2007-03-20 05:37:41 EST