Re: [Fastboot] Zero size /proc/vmcore on ia64

From: Horms <horms_at_verge.net.au>
Date: 2007-02-14 12:38:37
On Tue, Feb 13, 2007 at 06:03:20PM +0100, Bernhard Walle wrote:
> > Index: kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c
> > ===================================================================
> > --- kexec-tools-bw.orig/kexec/arch/ia64/crashdump-ia64.c	2007-02-13 17:39:18.000000000 +0900
> > +++ kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c	2007-02-13 18:09:44.000000000 +0900
> > @@ -232,13 +232,14 @@
> >  			if (crash_create_elf64_headers(info, &elf_info,
> >  						       crash_memory_range,
> >  						       nr_ranges,
> > -						       &tmp, &sz) < 0)
> > +						       &tmp, &sz,
> > +						       4096) < 0)
> 
> Why not using EFI_PAGE_SIZE here? It would also be good to find a
> suitable constant name for 1024.

Indeed, I meant to use EFI_PAGE_SIZE instead of 4096.
I'll fix that up and apply.

As for a good constant name, I'm open to suggestions.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Feb 14 13:44:06 2007

This archive was generated by hypermail 2.1.8 : 2007-02-14 13:44:21 EST