Re: [patch 3/3] IA64: virt_to_page() can be called with NULL arg

From: Jes Sorensen <>
Date: 2006-12-20 20:48:54
Kirill Korotaev wrote:
>>>>>>> "akpm" == akpm  <> writes:
>> akpm> From: Kirill Korotaev <> It does not return NULL
>> akpm> when arg is NULL.
>> Shouldn't the real fix be to track down who calls virt_to_page() with
>> a NULL pointer? IMHO it is bogus to do so.
> what do you propose? to insert BUG_ON(!kaddr) into virt_to_page()?
> in this case caller in question should be still fixed.

If you hit this, yes I'd insert the BUG_ON in your test kernel and fix
the code. Maybe add the BUG_ON in upstream for CONFIG_DEBUG or

Which callers did you see cause this? If it was a common problem I would
expect a lot of data corruption or crashes on ia64 systems which I
haven't heard of.

To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to
More majordomo info at
Received on Wed Dec 20 21:01:43 2006

This archive was generated by hypermail 2.1.8 : 2006-12-20 21:02:09 EST