Re: [patch] Cache error recovery

From: Hidetoshi Seto <seto.hidetoshi_at_jp.fujitsu.com>
Date: 2006-12-20 12:33:29
Russ Anderson wrote:
> @@ -688,11 +690,11 @@ recover_from_processor_error(int platfor
>  	 * The cache check and bus check bits have four possible states
>  	 *   cc bc
>  	 *    0  0	Weird record, not recovered
> -	 *    1  0	Cache error, not recovered
> +	 *    1  0	Cache error, attempt recovered
>  	 *    0  1	I/O error, attempt recovery
>  	 *    1  1	Memory error, attempt recovery
>  	 */

Which is right, attempt-"recovered" or "recovery"?

> -	if (psp->bc == 0 || pbci == NULL)
> +	if (psp->cc == 0 && (psp->bc == 0 || pbci == NULL))
>  		return fatal_mca("No bus check");

The message should be replaced by more appropriate one...
"No recoverable check" or just "Weird record"?

And also there are some comments need to be fixed since this
patch makes it incorrect, ex.

 >         /*
 >          * Well, here is only one bus error.
 >          */

Thanks,
H.Seto

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Dec 20 13:00:44 2006

This archive was generated by hypermail 2.1.8 : 2006-12-20 13:01:07 EST