Re: kexec/kdump and the ia64 test tree

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2006-10-03 03:35:01
> overall that plan seems fine to me - though I would have preferred
> a more incremental approach.

There are conflicting opinions on this on LKML ... some people believe
that it is better that the Linux change log represent history as it
should have been ... i.e. clean away all the goofs and mis-steps in
the sub-trees and send Linus the one true patch (or series of patches)
that do exactly what is wanted.  For the case of the white-space cleanup
part of the kexec/kdump patches, I can solidly get behind this opinion:
I can see no benefit to keeping separate patches that first mess-up
the whitespace, and then fix it.

On the other hand ... when there are real code changes involved, there
is definite benefit to preserving the dead-end development paths that
were abandoned (so that future debugging/development efforts at least
have the option to learn from our mistakes).  The removal of
ioc_iova_disable() almost falls into this category ... except that
we have already dropped the places where it was called, so if we
preserve it now, it would just be as the addition and immediate
removal of some dead code ... which looks to have less historical
value.

>                                I will spend some time today checking
> over your patch and see if I can spot any insanity.

Thanks for taking the time to do this.

> On a related note, does/did your ia64-test branch have anything
> of significance in it other than kexec/kdump?

There were a couple of other patches in "test" that I pulled over
to release and sent to Linus.  So kexec is all that is in there right
now.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Oct 03 03:35:37 2006

This archive was generated by hypermail 2.1.8 : 2006-10-03 03:35:48 EST