RE: [PATCH] fix prom revision checks in SN kernel

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2006-06-28 07:54:54
> Yeah, I didn't go for any clean up. We *shouldn't* be adding
> any more explicit prom rev. checks to the code because we
> now have an interface to check for prom "features" - see
> sn_prom_feature_available().

Recollections of that in the hind-brain prompted me to think
that there should be a better way.

> Unfortunately these checks were added before the interface
> was available and therefore the checks have to stay.

Makes sense.

> I can still do some clean up if preferred.

No, 3-places doesn't really justify invention of a generic
method ... and since you've already got a better method that
will prevent this from spreading elsewhere, I'll take it
as-is.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Jun 28 07:55:37 2006

This archive was generated by hypermail 2.1.8 : 2006-06-28 07:55:48 EST