RE: Small hugetlbpage.c fix

From: Chen, Kenneth W <kenneth.w.chen_at_intel.com>
Date: 2006-05-06 04:45:06
Zoltan Menyhart wrote on Friday, May 05, 2006 1:53 AM
> --- linux-2.6.16.9-save/arch/ia64/mm/hugetlbpage.c	2006-04-21 09:58:55.000000000 +0200
> +++ linux-2.6.16.9/arch/ia64/mm/hugetlbpage.c	2006-05-05 10:35:14.000000000 +0200
> @@ -125,9 +125,9 @@
>  
>  	addr = htlbpage_to_page(addr);
>  	end  = htlbpage_to_page(end);
> -	if (is_hugepage_only_range(tlb->mm, floor, HPAGE_SIZE))
> +	if (is_hugepage_only_range((*tlb)->mm, floor, HPAGE_SIZE))
>  		floor = htlbpage_to_page(floor);
> -	if (is_hugepage_only_range(tlb->mm, ceiling, HPAGE_SIZE))
> +	if (is_hugepage_only_range((*tlb)->mm, ceiling, HPAGE_SIZE))
>  		ceiling = htlbpage_to_page(ceiling);
>  
>  	free_pgd_range(tlb, addr, end, floor, ceiling);


Luck, Tony wrote on Friday, May 05, 2006 9:44 AM
> Greg, Chris:
> 
> 2.6.17-rcN has moved on and changed this in other ways, but
> this patch looks like a candidate for the stable series.
> What's there looks like it should kick a warning, if not a
> full blown error from the compiler for getting the type wrong.


What's the big fuss about it?  The first argument is not even used in
is_hugepage_only_range() for ia64.  Plus the fix is a broken fix anyway.

- Ken
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sat May 06 04:45:53 2006

This archive was generated by hypermail 2.1.8 : 2006-05-06 04:46:03 EST