Re: [PATCH] Fix percpu interrupt allocation in mmtimer code

From: Jes Sorensen <jes_at_sgi.com>
Date: 2006-03-16 22:02:34
>>>>> "Dimitri" == Dimitri Sivanich <sivanich@sgi.com> writes:

Dimitri> The timer interrupt in the mmtimer code needs to be allocated
Dimitri> as a percpu interrupt for acceptable performance on larger
Dimitri> systems.

Dimitri> The code needs to be updated to set this up properly, as the
Dimitri> SA_PERCPU_IRQ flag to request_interrupt is not supported.

Dimitri> +EXPORT_SYMBOL(register_percpu_irq);

Hi Dimitri,

EXPORT_SYMBOL_GPL() please.

Dimitri> +static irqreturn_t mmtimer_interrupt(int irq, void *dev_id, struct pt_regs *regs);
Dimitri> +

The prototype needs to go into a header file, it shouldn't be declared
in mmtimer.c. Also please make sure it doesn't exceed the 80 column
limit.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Mar 16 22:03:11 2006

This archive was generated by hypermail 2.1.8 : 2006-03-16 22:03:19 EST