Re: [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table)

From: Andi Kleen <ak_at_suse.de>
Date: 2006-03-09 15:56:04
On Thursday 09 March 2006 13:00, Andrew Morton wrote:
> Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> >  +		/* we can use kmalloc() in run time */
> >  +		do {
> >  +			table_size = zone->wait_table_size
> >  +					* sizeof(wait_queue_head_t);
> >  +			zone->wait_table = kmalloc(table_size, GFP_ATOMIC);
> 
> Again, GFP_KERNEL would be better is possible.
> 
> Won't this place the node's wait_table into a different node's memory?

Yes, kmalloc_node would be better.

-Andi


-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Mar 09 23:23:53 2006

This archive was generated by hypermail 2.1.8 : 2006-03-09 23:24:02 EST