RE: [patch] Increase severity of MCA recovery messages

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2006-02-28 08:40:05
> The MCA recovery messages are currently KERN_DEBUG,
> so they don't show up in /var/log/messages (by default).
> Increase the severity to KERN_CRIT, which is the 
> severity used when the kernel kills out of memory 
> processes.

-	printk(KERN_DEBUG "OS_MCA: process [cpu %d, pid: %d, uid: %d, "
+	printk(KERN_CRIT "OS_MCA: process [cpu %d, pid: %d, uid: %d, "

This one definitely needs a much bigger severity than DEBUG ... but is
it really as high as CRIT?  The whole point of the error recovery code
is that we (the system) do in fact recover (though at the expense of
killing a process).  Perhaps KERN_ERR?  But I'd like to hear opinions
on this.

-		printk(KERN_DEBUG "Page isolation: ( %lx ) success.\n", paddr);
+		printk(KERN_CRIT "Page isolation: ( %lx ) success.\n", paddr);

-		printk(KERN_DEBUG "Page isolation: ( %lx ) failure.\n", paddr);
+		printk(KERN_CRIT "Page isolation: ( %lx ) failure.\n", paddr);

But these ones ... I'm not so sure about.  We have already printed the first
message ... and don't take any different action whether we succeed or fail
at isolating the page.  Perhaps failure to isolate is a big problem, but
succesfully isolating isn't?  Though getting the physical address logged
would seem to be pretty useful (maybe it should be in the first printk?)

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 28 08:40:43 2006

This archive was generated by hypermail 2.1.8 : 2006-02-28 08:40:52 EST