On Tue, Jan 31, 2006 at 11:19:35AM +0000, Christoph Hellwig wrote: > Agreed. Obsfucating for a propritary and pretty much irrelevant (for the > kernel) compiler is a horrible thing to do. And the only reason we do that > at all is that the compiler is from the same company that's behind ia64. > Please fix up your damn compiler. Even SGI managed to add proper inline > as?embly support to Pro64, and they had much less ressources. How about we un-obfuscate the code by moving these three functions to a ".S" file? They are reading from uncached physical memory, and are packed full of "srlz.i" and ".acq"/".rel" options, so it doesn't appear that moving them from inline to a full procedure call would make any measurable difference to performance (at least not for any macrobenchmark). pio_phys_read_mmr() isn't even used anyplace, so we could further clarify the code by dropping it altogether. -Tony - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Wed Feb 01 05:09:58 2006
This archive was generated by hypermail 2.1.8 : 2006-02-01 05:10:08 EST