RE: [PATCH] SN2 user-MMIO CPU migration

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2006-01-24 11:48:50
> The following patch implements this behavior on SN2 by waiting for a
> Shub register to indicate that these writes have been accepted (the
> non-SN2 case is a no-op).  This is placed in the context switch-in
> path, and only performs the wait when the newly scheduled task changes
> CPUs.

> --- a/include/asm-ia64/system.h
> +++ b/include/asm-ia64/system.h
> @@ -243,6 +243,7 @@ extern void ia64_load_extra (struct task
> 		(prev)->thread.flags |= IA64_THREAD_FPH_VALID;			\
> 		__ia64_save_fpu((prev)->thread.fph);				\
> 	}									\
> +	platform_switch_from(next);						\
>  	__switch_to(prev, next, last);						\
>  } while (0)

On a generic kernel running on non-sn2 h/w, surely this just
added a function call to an empty function into every context
switch?

Thinking about this a bit more, wouldn't it be better to do this
work in the rebalance code that is making the decision to move
the process.  The earlier argument that this would sometimes
waste time because the process might not actually move doesn't
sound so strong ... we context switch frequently, we move processes
rarely.  Doing some work that may be wasted in the rare path sounds
better than always doing work in the common path.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Jan 24 11:49:27 2006

This archive was generated by hypermail 2.1.8 : 2006-01-24 11:49:35 EST