Re: [PATCH] cleanup XPC disengage related messages (v2)

From: Andreas Schwab <schwab_at_suse.de>
Date: 2006-01-06 09:04:41
Dean Nelson <dcn@sgi.com> writes:

> +		if (xpc_partition_engaged(-1UL)) {
> +			if (jiffies >= printmsg_time) {

This should use time_after().

> +			if (!(volatile int) xpc_disengage_request_timedout) {

This cast is useless.  Qualifiers are ignored on non-lvalues.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Jan 06 09:07:30 2006

This archive was generated by hypermail 2.1.8 : 2006-01-06 09:07:37 EST