[PATCH] incorrect return from ia64_pci_legacy_write()

From: Alex Williamson <alex.williamson_at_hp.com>
Date: 2005-12-22 09:21:36

   Maybe there's time for one more push to Linus?  The function
ia64_pci_legacy_write() returns 0 for everything except errors.  This
return value gets sent back to the user from pci_write_legacy_io(),
making it look like every write fails.  The trivial patch below copies
the behavior of the SGI sn machvec and does what would be expected from
something implementing a write() function.  Please apply, Thanks,


Signed-off-by: Alex Williamson <alex.williamson@hp.com>

diff -r 513446906e2e arch/ia64/pci/pci.c
--- a/arch/ia64/pci/pci.c	Wed Dec 21 19:05:15 2005
+++ b/arch/ia64/pci/pci.c	Wed Dec 21 14:52:44 2005
@@ -700,7 +700,7 @@
 int ia64_pci_legacy_write(struct pci_dev *bus, u16 port, u32 val, u8 size)
-	int ret = 0;
+	int ret = size;
 	switch (size) {
 	case 1:

To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Dec 22 09:22:11 2005

This archive was generated by hypermail 2.1.8 : 2005-12-22 09:22:18 EST