Re: [PATCH] ia64: eliminate softlockup warning

From: Andrew Morton <akpm_at_osdl.org>
Date: 2005-12-15 10:16:13
hawkes@sgi.com wrote:
>
> Fix an unnecessary softlockup watchdog warning in the ia64
> uncached_build_memmap() that occurs occasionally at 256p and always at
> 512p.  The problem occurs at boot time.
> 
> It would be good if we had a cleaner mechanism to temporarily silence
> the watchdog thread, e.g.,
>     http://marc.theaimsgroup.com/?l=linux-kernel&m=111552476401175&w=2
> but until that patch gets merged, this fix will have to suffice.
> 

That patch is for the hangcheck timer driver which is unrelated to the
softlockup detector.

> 
> Index: linux/arch/ia64/kernel/uncached.c
> ===================================================================
> --- linux.orig/arch/ia64/kernel/uncached.c	2005-12-06 15:12:14.000000000 -0800
> +++ linux/arch/ia64/kernel/uncached.c	2005-12-14 14:50:55.000000000 -0800
> @@ -210,6 +210,7 @@
>  
>  	dprintk(KERN_ERR "uncached_build_memmap(%lx %lx)\n", start, end);
>  
> +	touch_softlockup_watchdog();
>  	memset((char *)start, 0, length);
>  
>  	node = paddr_to_nid(start - __IA64_UNCACHED_OFFSET);

Yes, additions like this are a bit awkward, but they're not _that_ bad.  It
says "this code is doing something unusual".  It's an explicit marker which
we can grep for and which conveys useful information about an exceptional
kernel state.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Dec 15 10:15:23 2005

This archive was generated by hypermail 2.1.8 : 2005-12-15 10:15:30 EST