Re: [PATCH]: Prevent sn2 ptc code from executing on all ia64 subarches

From: Bjorn Helgaas <bjorn.helgaas_at_hp.com>
Date: 2005-12-14 04:47:14
On Tuesday 13 December 2005 10:24 am, Luck, Tony wrote:
> > I think this is too complicated.  Initcall ordering is fragile as it
> > is. 
> ...
> 
> > Can you use the existing machine vector infrastructure to solve this
> > problem?  For example, what if you added a "platform_device_setup()"
> > hook that is a no-op on most platforms, but maps to sn_device_setup()
> > in the SN2 machine vector?  platform_device_setup() would itself be
> > called as a device_initcall().
> 
> This solution would move all the sn2 initializaions into the
> device_initcall sequence.  Which might cause some ordering
> problems.  E.g. sn_pci_init() is a "subsys_initcall" ... and I
> expect that it really needs to happen before any of the
> device_initcalls.

Well, sure.  device_setup() was just an example.  I expect they'd
want to add more (subsys, etc).  I doubt that all the levels would
be needed, but even if they were, I'd prefer it over sprinkling
"ia64_platform_is" everywhere.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Dec 14 04:48:17 2005

This archive was generated by hypermail 2.1.8 : 2005-12-14 04:48:24 EST