Re: [PATCH] fix memory less node allocation

From: Bob Picco <bob.picco_at_hp.com>
Date: 2005-11-04 11:10:39
luck wrote:	[Thu Nov 03 2005, 05:33:53PM EST]
> -	if (!ptr)
> -		panic("NO memory for memory less node\n");
> 
> Why did you drop this panic?  Although your patch now
> makes sure to never try to alloc from a memory less
> node ... surely it is still possible (though unlikely)
> that the call to __alloc_bootmem_node() might fail. A
> panic here might be easier to debug than letting it run
> until fill_pernode() does a memset(__va(0), 0, ...).
> 
> -Tony
I dropped it because it seemed redundant. __alloc_bootmem_node calls 
__alloc_bootmem_node_limit who calls __alloc_bootmem_core for this
node. Should __alloc_bootmem_core core fail, then call __alloc_bootmem_limit.
__alloc_bootmem_limit attempts to allocate from any node. Should 
__alloc_bootmem_limit (old name __alloc_bootmem)  fail, then it panics.

bob
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Nov 04 11:10:53 2005

This archive was generated by hypermail 2.1.8 : 2005-11-04 11:10:59 EST