Re: [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes

From: Matthew Wilcox <matthew_at_wil.cx>
Date: 2005-09-23 03:13:40
On Thu, Sep 22, 2005 at 09:36:16AM -0700, Dave Hansen wrote:
> >  
> > -	return (i < num_node_memblks) ? node_memblk[i].nid : (num_node_memblks ? -1 : 0);
> > +	return (i < num_node_memblks) ?
> > +		node_memblk[i].nid : (num_node_memblks ? -1 : 0);
> >  }
> 
> Looks like just a whitespace change.

But really far less radical than it deserves ... nested conditional
expressions?  Come on.  How about:

	if (i < num_node_memblks)
		return node_memblk[i].nid;
	if (num_node_memblks)
		return -1;
	return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Sep 23 03:14:25 2005

This archive was generated by hypermail 2.1.8 : 2005-09-23 03:14:32 EST