Re: Remove warnings for gcc 4.0 IA64 compilation.

From: Peter Chubb <peterc_at_gelato.unsw.edu.au>
Date: 2005-09-19 09:10:14
Tony Luck wrote: 
On Thu, Sep 15, 2005 at 03:36:35PM +1000, Peter Chubb wrote:
> Index: linux-2.6-import/arch/ia64/kernel/time.c
> -	printk(KERN_DEBUG "CPU %d: base freq=%lu.%03luMHz, ITC ratio=%lu/%lu, "
> +	printk(KERN_DEBUG "CPU %d: base freq=%lu.%03luMHz, ITC ratio=%u/%u, "
>  	       "ITC freq=%lu.%03luMHz", smp_processor_id(),
>  	       platform_base_freq / 1000000, (platform_base_freq / 1000) % 1000,
>  	       itc_ratio.num, itc_ratio.den, itc_freq / 1000000, (itc_freq / 1000) % 1000);

Tony> This hunk is surely wrong?  itc_freq is unsigned long, so
Tony> itc_freq/1000000 still has unsigned long type.

Sure, but itc_ratio.num and itc_ratio.den (which are the only bits
affected, unless I've severely miscalculated the match between format
and args) are both 32-bit quantities

Peter C
--
Dr Peter Chubb  http://www.gelato.unsw.edu.au  peterc AT gelato.unsw.edu.au
The technical we do immediately,  the political takes *forever*
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Sep 19 09:11:14 2005

This archive was generated by hypermail 2.1.8 : 2005-09-19 09:11:51 EST