RE: Xen and the Art of Linux/ia64 Virtualization

From: Magenheimer, Dan (HP Labs Fort Collins) <dan.magenheimer_at_hp.com>
Date: 2005-07-16 22:55:27
> Looks nice.  One thing that bothers me is that privop.h is unsymmetic,
> I'd rather see the Xen variants of the routines in 
> asm/privop.h aswell.

Thanks!  Do you mean like:

#ifdef CONFIG_XEN
#include <asm/xen/privop.h>
#define privop1 xen_privop1
#define privop2(x) xen_privop2(x)
 :
#else
#define privop1 __privop1
#define privop2(x) __privop2(x)
 :
#endif

> Also in the early console setup please put the return on a 
> separate line
> from the if clause.

OK, will do in Rev4.

> It would be very nice if you could submit the additional abstractions
> as a first patch as soon as possible and post a full patch ontop of it
> later that includes the new files aswell.

That's the plan.

Thanks very much for the feedback!
Dan
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sat Jul 16 08:55:46 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:40 EST