Re: [patch 4/4] ia64 SPARSEMEM - SPARSEMEM code changes

From: Jesse Barnes <jesse.barnes_at_intel.com>
Date: 2005-05-24 04:08:28
On Monday, May 23, 2005 10:51 am, Bob Picco wrote:
> +#ifdef	CONFIG_SPARSEMEM
> +/**
> + * register_sparse_mem - notify SPARSEMEM that this memory range
> exists. + * @start: physical start of range
> + * @end: physical end of range
> + * @arg: unused
> + *
> + */

No comment for the function (I guess it's pretty simple...).

> +static int __init register_sparse_mem(unsigned long start, unsigned
> long end, +	void *arg)
> +{
> +	int nid;
> +
> +	start = __pa(start) >> PAGE_SHIFT;
> +	end = __pa(end) >> PAGE_SHIFT;
> +	nid = early_pfn_to_nid(start);
> +	(void) memory_present(nid, start, end);

Is the (void) cast necessary?

> +#ifdef	CONFIG_SPARSEMEM
> +	efi_memmap_walk(register_sparse_mem, (void *) 0);
> +#endif

NULL here instead?

> -#ifndef CONFIG_DISCONTIGMEM
> +#ifndef	CONFIG_NEED_MULTIPLE_NODES

Just use a space instead of a tab I think.

> +#if	defined(CONFIG_SPARSEMEM) && defined(CONFIG_NUMA)

Ditto.

> +/*
> + * Because of holes evaluate on section limits.
> + */

A better comment block here maybe describing return values and such?

> +int early_pfn_to_nid(unsigned long pfn)
> +{
> +	int i, section = pfn >> PFN_SECTION_SHIFT, ssec, esec;
> +
> +	for (i = 0; i < num_node_memblks; i++) {
> +		ssec = node_memblk[i].start_paddr >> PA_SECTION_SHIFT;
> +		esec = (node_memblk[i].start_paddr + node_memblk[i].size +
> +			((1L << PA_SECTION_SHIFT) - 1)) >> PA_SECTION_SHIFT;
> +		if (section >= ssec && section < esec)
> +			break;
> +	}
> +
> +	if (i == num_node_memblks)
> +		return 0;
> +	else
> +		return node_memblk[i].nid;

You could just drop the else here if you wanted, maybe along with a 
comment by the return 0 saying that the pfn wasn't found?  Or you could 
turn the 'break' above into return node_memblk[i].nid and make the 
function return 0 unconditionally if the for loop exited.

So other than that cosmetic stuff, this patch looks ok.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon May 23 14:08:40 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:39 EST