Re: [Pcihpd-discuss] [PATCH 5/6]: hotplug/ia64: SN Hotplug Driver - SN Hotplug Driver code

From: Prarit Bhargava <prarit_at_sgi.com>
Date: 2005-05-21 09:47:34
Greg KH wrote:
> On Fri, May 20, 2005 at 08:11:30AM -0400, Prarit Bhargava wrote:
> 
>>+static struct hotplug_slot_attribute sn_slot_attrs[] = {
>>+	__ATTR_RO(path),
>>+	__ATTR_NULL
>>+};
> 
> 
> Why are you having an array with only 1 attribute?  Just define the one,
> and live with it.  That way you can get rid of all of your odd loops.

Sorry -- all the examples I found used __ATTR_RO in an array.  I thought 
  that was the way you wanted the attributes defined.  I would prefer to 
have a single attribute as well.

I'll modify and retest ...

Thanks,

P.


-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri May 20 19:48:01 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:39 EST