Re: [Pcihpd-discuss] [PATCH 5/6]: hotplug/ia64: SN Hotplug Driver - SN Hotplug Driver code

From: Greg KH <greg_at_kroah.com>
Date: 2005-05-20 01:13:53
On Thu, May 19, 2005 at 09:05:47AM -0400, Prarit Bhargava wrote:
> +static struct hotplug_slot_attribute sn_slot_attr_path = {
> +	.attr = {.name = "path", .mode = S_IFREG | S_IRUGO},
> +	.show = sn_read_path_file,
> +};

No, you did not properly initialize all of the attribute fields, so your
module could be unloaded when the sysfs file is open :(

Please use the proper macro for this: __ATTR_RO()

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu May 19 11:12:24 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:39 EST