Re: [patch] fix HP simulator smp build replace __devinit -> __devinitdata (revised)

From: Darren Williams <dsw_at_gelato.unsw.edu.au>
Date: 2005-05-09 21:21:39
Hi Keith

On Mon, 09 May 2005, Keith Owens wrote:

> On Mon, 9 May 2005 16:57:11 +1000, 
> Darren Williams <dsw@gelato.unsw.edu.au> wrote:
> >Since we have updated the Autobuild system to use Cogito
> >we can start to report and submit patches on the latest
> >check-ins that break the build.
> >
> >Currently on the Gelato@UNSW Autobuild system:
> >http://www.gelato.unsw.edu.au/kerncomp/
> >we are seeing the sim_defconfig build fail, with the
> >following error:
> >
> >arch/ia64/kernel/smpboot.c:627: error: mt_info causes a section type conflict
> >
> >the following non-git patch fixes the problem, tested
> >on simulator, and zx1. I'm not sure why the simulator
> >is triggering this build failure since zx1 sn2 are
> >building OK?
> 
> __devinit is a no-op when CONFIG_HOTPLUG=y.  zx1 and sn2 configs enable
> HOTPLUG, sim_defconfig does not.
> 
> 
> That should be __devinitdata, not __initdata.

Revised patch, thanks Keith
Tested for compile and boot on zx1 and simulator. 

Signed-off-by:  Darren Williams <dsw@gelato.unsw.edu.au>


--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Received on Mon May 9 07:21:54 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:38 EST