Re: Incorrect return types for atomic64 functions in IA64 atomic.h

From: Jerry Feldman <gerald.feldman_at_hp.com>
Date: 2005-04-30 05:39:12
On Friday 29 April 2005 3:10 pm, Andreas Schwab wrote:
> Jerry Feldman <gerald.feldman@hp.com> writes:
> > @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
> >         return atomic_add_return(i, v) < 0;
> >  }
> >
> > -static __inline__ int
> > +static __inline__ __s64
> >  atomic64_add_negative (__s64 i, atomic64_t *v)
> >  {
> >         return atomic64_add_return(i, v) < 0;
>
> This is wrong.  The return value is a boolean.
I agree. Should I resubmit the patch corrected, or will someone else do it.

-- 
Jerry Feldman <gerald.feldman@hp.com>
Partner Technology Access Center (contractor) (PTAC-MA)
Hewlett-Packard Co.
550 King Street LKG2a-X2
Littleton, Ma. 01460
 (978)506-5243
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Apr 29 15:39:43 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST