Re: Incorrect return types for atomic64 functions in IA64 atomic.h

From: Andreas Schwab <schwab_at_suse.de>
Date: 2005-04-30 05:10:50
Jerry Feldman <gerald.feldman@hp.com> writes:

> @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
>         return atomic_add_return(i, v) < 0;
>  }
>  
> -static __inline__ int
> +static __inline__ __s64
>  atomic64_add_negative (__s64 i, atomic64_t *v)
>  {
>         return atomic64_add_return(i, v) < 0;

This is wrong.  The return value is a boolean.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Apr 29 15:22:53 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST