RE: write_unlock: replace clear_bit with byte store

From: Chen, Kenneth W <kenneth.w.chen_at_intel.com>
Date: 2005-04-29 11:48:34
Chen, Kenneth W wrote on Thursday, April 28, 2005 6:04 PM
> Christoph Lameter wrote on Thursday, April 28, 2005 5:51 PM
> 
> > +static inline void _raw_write_unlock(rwlock_t *x) {
> > +	barrier();
> > +	x->write_lock = 0;
> > +}
> > +
> >  #endif /* !ASM_SUPPORTED */
> 
> This portion is broken, where is the release semantics for updating
> the lock variable?  Or where is the smp_mb() if you decide to use an
> unordered store for the lock variable?

Oops, never mind.  Missed the portion that write_lock is declared as
volatile.  My bad.  This code is OK.

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Apr 28 21:49:07 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST