Re: [Pcihpd-discuss] Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

From: Bjorn Helgaas <bjorn.helgaas_at_hp.com>
Date: 2005-04-23 00:56:19
On Fri, 2005-04-22 at 09:53 +0200, Rolf Eike Beer wrote:
> Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:
> > Hi Bjorn,
> 
> > > Nitpick: these declarations should follow the style of the rest
> > > of the file, i.e., add a space between the function name and the
> > > opening parenthesis.
> >
> > Thank you very much for comments.
> > I'll update my patches based on your comments.
> 
> No, please don't do this. It just causes me to send another patch to kill them 
> alltogether.

Don't be silly.  If you want to change the whole file to conform to
one style, fine.  I even agree with the sentiment that arch/ia64
would be better off if it were more consistent with the rest of the
kernel.

But isolated changes to a file should follow the style of the rest
of the file.

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Apr 22 11:00:06 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST