Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

From: Kenji Kaneshige <kaneshige.kenji_at_jp.fujitsu.com>
Date: 2005-04-22 16:38:30
Hi Bjorn,

Thank you very much for comments.
I'll update my patches based on your comments.

Regards,
Kenji Kaneshige


Bjorn Helgaas wrote:
>>+++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c	2005-04-20 10:51:30.136299152 +0900
>>@@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
>> 	return AE_OK;
>> }
>> #endif /* CONFIG_NUMA */
>>+
>>+int
>>+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
>>+{
>>+	/* TBD */
>>+	return -EINVAL;
>>+}
>>+EXPORT_SYMBOL(acpi_register_ioapic);
>>+
>>+int
>>+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
> 
> 
> Nitpick: these declarations should follow the style of the rest
> of the file, i.e., add a space between the function name and the
> opening parenthesis.
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Apr 22 02:39:08 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST