Re: [mpm@selenic.com: Re: buggy ia64_fls() ? (was Re: /dev/random problem on 2.6.12-rc1)]

From: Andrew Morton <akpm_at_osdl.org>
Date: 2005-04-09 04:02:47
Matt Mackall <mpm@selenic.com> wrote:
>
> One wonders if:
> 
>   return ia64_getf_exp(d) & 0x3f;
> 
>  is the right fix.

Yes, that'll give the right result for fls(-1).  But what'll it give for
fls(-2)?

> The fact that it's using floating point is... weird.
> 
>  Work around broken IA64 fls.

I'd be more inclined to make ia64 use generic_fls() until someone can get
in there and fix it for real.



-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Apr 8 14:06:05 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST