Re: [PATCH] Pageset Localization V2

From: Matthew Wilcox <matthew_at_wil.cx>
Date: 2005-03-30 23:40:49
On Tue, Mar 29, 2005 at 09:51:08PM -0800, Christoph Lameter wrote:
> +	BUG_ON(process_zones(smp_processor_id()));

No.  Who told you this was a good idea?  This is the *worst* kind of
assert, calling a function with side-effects.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Mar 30 08:41:12 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST