Re: [PATCH 3/91] get rid of pci_find_{device,subsys} arch/ia64

From: Greg KH <greg_at_kroah.com>
Date: 2005-03-30 19:45:51
On Wed, Mar 30, 2005 at 12:29:00PM +0530, Amit Gud wrote:
> So if we are to replace pci_find_device with pci_get_device, how should we 
> go about in this particular case, which
> apparently is the case with many other places where pci_find_device is 
> used. The way I did seemed logical to me:
> find the device - accept it - work with it - jerk it off.
> Am I missing out something very obvious?

Please read the last sentence of the documentation for the
pci_get_device() function.  I think you missed that :)

That sentence tells us that you do not need to call pci_dev_put() within
a pci_get_device() while loop.

So please, email all of the maintainers who you sent those patches to
and ask them to not apply them...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Mar 30 04:46:18 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST