Re: [PATCH 3/3] SGI Altix cross partition functionality (2nd revision)

From: David S. Miller <davem_at_davemloft.net>
Date: 2005-03-24 07:02:48
On Wed, 23 Mar 2005 13:51:39 -0600
Dean Nelson <dcn@sgi.com> wrote:

> This patch contains the cross partition pseudo-ethernet driver (XPNET)
> functional support module.
> 
> Signed-off-by: Dean Nelson <dcn@sgi.com>

Only a NIT or two.  You should be setting the last_rx
value.  Also, NETIF_F_HIGHDMA is pointless unless you
support NETIF_F_SG and thus paged SKBs.  skb->data will
never be placed in high memory, only non-linear SKB
scatterlist pages will.

I should probably add a debugging check at device
registration time, like we already do to make sure
NETIF_F_SG is not set unless some checksumming
capability is there as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Mar 23 15:03:12 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:37 EST