Re: [Patch 1/3] Reclaim pmd and pte entries to quicklists.

From: Robin Holt <holt_at_sgi.com>
Date: 2005-03-03 07:44:37
On Wed, Mar 02, 2005 at 10:43:41AM -0800, David Mosberger wrote:
> >>>>> On Wed, 2 Mar 2005 12:33:25 -0600, Robin Holt <holt@sgi.com> said:
> 
>   >> I wasn't suggesting to support multiple sizes, just to add a
>   >> BUG_ON(size != PAGE_SIZE) or something like that.
> 
>   Robin> What is the motivation for this?
> 
> To make the kernel more resilient against inconsistencies.  Sure, it
> won't be perfect, but while mucking with it anyway, why not improve
> it?  Me thinks you'd want something along the lines of:
> 
> pgd_alloc:
> 
> 	...
> 	pgd = alloc_one_fast(mm, PTRS_PER_PGD * sizeof(pgd_t));

Since the size of page tables does not change on a running system,
would you accept three BUG_ONs in mm/init.c that check pgd, pmd, and
pte allocation sizes?  That will be clearer and definitely not have any
chance of impacting runtime.

Thanks,
Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Mar 2 15:46:21 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:36 EST