RE: [patch -mm series] ia64 specific /dev/mem handlers

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2005-02-23 05:05:42
>On Tue, Feb 22, 2005 at 09:41:04AM -0500, Jes Sorensen wrote:
>> >> + if (page->flags & PG_uncached)
>> 
>> Andrew> dude.  That ain't gonna work ;)
>> 
>> Pardon my lack of clue, but why not?
>
>I think you're supposed to always use test_bit() to check page flags

You defined PG_uncached as "20" ... so either:

	if (page->flags & (1<<PG_uncached))

or (much better) to use:

	test_bit(PG_uncached, &page->flags).

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 22 13:09:23 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:36 EST