Re: [PATCH] Errenous use of memset and memcpy

From: Bjorn Helgaas <bjorn.helgaas_at_hp.com>
Date: 2005-02-23 04:37:10
On Sun, 2005-02-20 at 11:38 +0100, Alexander Nyberg wrote:
> ===== arch/ia64/ia32/ia32_signal.c 1.35 vs edited =====
> --- 1.35/arch/ia64/ia32/ia32_signal.c	2005-01-25 21:23:45 +01:00
> +++ edited/arch/ia64/ia32/ia32_signal.c	2005-02-20 11:32:55 +01:00
> @@ -460,9 +460,9 @@ __ia32_rt_sigsuspend (compat_sigset_t *s
>  	sigset_t oldset, set;
>  
>  	scr->scratch_unat = 0;	/* avoid leaking kernel bits to user level */
> -	memset(&set, 0, sizeof(&set));
> +	memset(&set, 0, sizeof(sigset_t));

To check that the above is correct, you have to go look up
the declaration of "set".  Why not do this:

+	memset(&set, 0, sizeof(set));

which is clearly correct, regardless of the declaration?

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 22 12:39:54 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:36 EST