On Fri, 14 Jan 2005, Arun Sharma wrote: > On 1/14/2005 8:52 AM, Jason Baron wrote: > > hi, > > > > It seems that in ia64_elf32_init, instead of calling return, if we insert > > an overlapping vma, we should instead BUG(). We should never get into this > > code path, because the vma's are set above PAGE_OFFSET, and thus a > > Xmalicious user can not trigger this code path. This change is being > > suggested mainly for clarity. Thanks to Stephen Tweedie for pointing out > > that returning early in ia64_elf32_init could have unpredictable results. > > > > Couldn't you get rid of a couple of more lines before the BUG()? Otherwise, the patch looks good to me. > > -Arun > > It kind of makes sense to free the vma, since its not linked in yet, and thus wouldn't be freed up via exit_mm. However, i don't really have a strong preference either way -Jason - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Mon Jan 17 13:43:23 2005
This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:34 EST