Re: [patch] add BUG call to overlapping vma fix

From: Arun Sharma <arun.sharma_at_intel.com>
Date: 2005-01-15 10:36:13
On 1/14/2005 8:52 AM, Jason Baron wrote:
> hi,
> 
> It seems that in ia64_elf32_init, instead of calling return, if we insert
> an overlapping vma, we should instead BUG(). We should never get into this
> code path, because the vma's are set above PAGE_OFFSET, and thus a
> Xmalicious user can not trigger this code path. This change is being
> suggested mainly for clarity. Thanks to Stephen Tweedie for pointing out
> that returning early in ia64_elf32_init could have unpredictable results.
> 

Couldn't you get rid of a couple of more lines before the BUG()? Otherwise, the patch looks good to me.

	-Arun


-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Jan 14 18:39:18 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:34 EST