RE: [patch] per cpu MCA/INIT fixes.

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2005-01-07 05:28:19
>The above will probably conflict with Jack's recent change to 
>stagger the per-node structures by one cacheline.  You may have to rediff 
>against one of Tony's test trees.

I just applied and pushed Jack's patch to the test-2.6.11 tree, Russ, can
you fix up your patch to apply cleanly on top of Jack's.

>> +#ifdef CONFIG_SMP
>> +#include <asm/mca.h>
>> +#endif
>
>Just a nit, header files should always be safe to include 
>unconditionally.  If they're not, the headers need fixing (barring out of tree 
>stuff like kdb of course).

Agreed ... this looks really ugly ... surely we want to support MCA
on uni-processors as well as SMP!  What's the issue that provoked
adding the #ifdef here?

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Jan 6 13:35:16 2005

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:34 EST