Re: [PATCH] fix phys. address conversion in ia64_pal_tr_read

From: Jesse Barnes <jbarnes_at_engr.sgi.com>
Date: 2004-11-17 04:01:49
On Monday, November 15, 2004 6:03 pm, David Mosberger wrote:
> >>>>> On Mon, 15 Nov 2004 17:22:41 -0800, Jesse Barnes
> >>>>> <jbarnes@engr.sgi.com> said:
>
>   Jesse> The palinfo module may call ia64_pal_tr_read using an IPI.
>   Jesse> If the processor receiving the IPI is idle, the call will
>   Jesse> fail since the idle process stack is in region 5 and
>   Jesse> ia64_pal_tr_read uses __pa rather than ia64_tpa.  This small
>   Jesse> patch fixes the problem by making it use ia64_tpa instead.
>
> Perhaps its worthwhile to do any audit for this kind of problems?  It
> may not be very difficult to hack sparse to add a check for __pa()
> calls on (stack-)local variables.

I didn't see anything obvious in a quick check of all the ia64 users of __pa 
(they were mostly referring to stuff in the static data section), but I may 
have missed something.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Nov 16 12:04:10 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:32 EST