Re: [PATCH] 2.6 SGI Altix I/O code reorganization

From: Patrick Gefre <pfg_at_sgi.com>
Date: 2004-10-06 09:30:17
Christoph Hellwig wrote:

> This looks pretty nice already, but a few small but important issues
> need sorting out.
> 
>  - The interface between pci_dma.c and the lowlevel code is still wrong -
>    and because of the additional 32bit direct translation in this code drop
>    it got even worse because you might be calling into a function just to
>    error out again.
>    Please implement my suggestions from month ago, it's not a lot of work.
>  - various sall baclls take bus_number and devfs but no pci domain, while
>    the normal SAL calls do, I think you should make the kernel code aware
>    of pci domains so the prom can introduce them seamlessly
>  - is doing SAL calls from irq context really safe?  Also why do you need
>    different SAL calls for shub vs ice error?  The prom should be easily
>    able to find out what hub a given nasid corresponds to.
>  - the patch reformats various unrelated or only slightly related files.
>    Please don't do that - in general the new style is better than the old
>    one, but it doesn't belong in this patchA
>  - there's a SNDRV_SHUB_GET_IOCTL_VERSION ioctl define added but never
>    used.  In fact it looks like all SNDRV_SHUB_ values are unused now?
> 

Christoph,

Thanks for the review. We're working on spinning up a new version with these changes.

Also the issue of where to put sn_pci_set_vchan().... I had originally put it in 
include/asm-ia64/sn/io.h, but then this file doesn't get picked up for generic and others...

So I'm looking for some guidance... almost seems like putting it in qla1280.c is the most obvious - 
since it is only used there and then there isn't include file fooling around to do.

-- Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Oct 5 19:36:20 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:31 EST