Re: yet another sparse-detected bug fix

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2004-10-05 17:21:26
>>>>> On Mon, 04 Oct 2004 12:46:41 -0700, Arun Sharma <arun.sharma@intel.com> said:

  Arun> On 10/4/2004 8:45 AM, David Mosberger wrote:
  Arun> Hi David,

  >> Arun,
  >> 
  >> copy_siginfo_from_user32() directly dereferences a user-pointer, which
  >> is a no-no.  At that point, to->si_code already has been initialized
  >> so I think we can just use to->si_code instead.  Compile-tested (only)
  >> patch attached.
  >> 
  >> Signed-off-by: davidm@hpl.hp.com

  Arun> I've been meaning to run sparse myself. But it wasn't very effective the last time I tried because of the missing __user annotations.

  Arun> Please review the attached patches that add the missing
  Arun> annotations so that we can make it easy to spot these errors
  Arun> in the future.

I'm confused.  I posted a sparse-enablement patch yesterday.  Was
there something wrong with that one?

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Oct 5 03:21:39 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:31 EST